Improve the quality and readability of Hydra's DocumentationNormalizer #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Sep 6, 2016
dunglas
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
| $shortName = $resourceMetadata->getShortName(); | ||
| $prefixedShortName = ($iri = $resourceMetadata->getIri()) ? $iri : '#'.$shortName; | ||
| $prefixedShortName = (null === $iri = $resourceMetadata->getIri()) ? '#'.$shortName : $iri; |
There was a problem hiding this comment.
Yes, or $iri will not be defined.
dunglas
force-pushed
the
hydra_doc_quality
branch
from
cdad24d to
3323818
Compare
dunglas
force-pushed
the
hydra_doc_quality
branch
from
3323818 to
a2b5083
Compare
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
Improve the quality and readability of Hydra's DocumentationNormalizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.