-
-
Notifications
You must be signed in to change notification settings - Fork 933
fix: allow description and other fields to be override seperately #7442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow description and other fields to be override seperately #7442
Conversation
can you target 4.2? |
@soyuka 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me and just require test
And I wonder if the same is required for XMLExtractor |
@VincentLanglet I will add tests and also fix this for XMLExtractor EDIT: XMLExtractor already works https://github.com/ceesvanegmond/core/blob/fix/override-description-in-yaml-operation/src/Metadata/Extractor/XmlResourceExtractor.php#L205 |
It creates an array while it would be better to instanciate a Route object |
@VincentLanglet I guess you mean |
Note that with Symfony deprecating the xml configuration less and less people are going to use that. |
thanks! |
This PR adds functionality to override the description and other fields from YAML. Previously, this was possible using annotations, but currently, it's not possible to override only the description. While it is possible to override the response HTTP status, doing so replaces the entire key. With this change, you can now override just the description field.