Revert "Remove partial select" #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
revert-remove-partial-select
branch
2 times, most recently
from
9be5033 to
2bb9c2d
Compare
This reverts commit 8efed0b.
soyuka
force-pushed
the
revert-remove-partial-select
branch
from
2bb9c2d to
57afc29
Compare
soyuka
changed the title
teohhanhui
approved these changes
Nov 29, 2016
Simperfit
approved these changes
Nov 30, 2016
|
Thanks @soyuka |
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
…-select Revert "Remove partial select"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the bad review on my end but if we remove the
selectpart, Doctrine ends up doing joins without selecting the joined tables, and then does lazy join again...We can remove the
partialand add instead$queryBuilder->addSelect($associationAlias);if you don't want to use partial. However, partial does only fetch the wanted data, and IMO it's better than selecting everything (ie SQL query is more readable).Changes the way ManyToMany are handled as we can't now for sure that the related data exists, even if the joinTables columns are null.