Skip to content

Update security ApiProperty variables #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2022
Merged

Update security ApiProperty variables #1351

merged 2 commits into from
Mar 13, 2022

Conversation

xavren
Copy link
Contributor

@xavren xavren commented Apr 23, 2021

No description provided.

@alanpoulain
Copy link
Member

Thanks but I think it's better to favor this one: #1349.

@xavren
Copy link
Contributor Author

xavren commented Apr 27, 2021

Hey @alanpoulain,

request is actually unavailable from variables in this context
object is not the current resource during denormalization but the resourceClass

The PR #1349 actually is adding some informations about previous object that is nice but different from this PR, merging this contributions would be nice

@alanpoulain
Copy link
Member

I didn't see the part about the request, sorry.
For the object, it will be null instead of the resource class when api-platform/core#4184 is merged. But it will be on main, so I guess we can merge your PR in the meantime.
I have been too quick, sorry!

@alanpoulain alanpoulain reopened this Apr 27, 2021
@alanpoulain
Copy link
Member

alanpoulain commented Apr 27, 2021

Is user available?
Edit: it seems so, in ResourceAccessChecker.
There are also the token and the roles, maybe it would be nice to add them?

@xavren
Copy link
Contributor Author

xavren commented Apr 27, 2021

Yes, user is there too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants