Update caddy.md #1532
Merged
Update caddy.md #1532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Apr 15, 2022
| @@ -31,5 +31,5 @@ For instance, if you want to route all requests to a path starting with `/admin` | |||
| {header.Accept}.matches("\\btext/html\\b") | |||
| - && !{path}.matches("(?i)(?:^/docs|^/graphql|^/bundles/|^/_profiler|^/_wdt|\\.(?:json|html$|csv$|ya?ml$|xml$))") | |||
| + && !{path}.matches("(?i)(?:^/admin|^/docs|^/graphql|^/bundles/|^/_profiler|^/_wdt|\\.(?:json|html$|csv$|ya?ml$|xml$))") | |||
There was a problem hiding this comment.
You also added admin here though.
There was a problem hiding this comment.
I did not; it was already there. If you look at the refined diff, I only added the backtick at the end.
I think GitHub is erroneously rendering these lines of the patch block as part of this patch, which didn't actually change. The only change is L34.
|
Thanks Matt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a big deal, just a closing backtick seems to be missing here. 🤷♂️