Skip to content

refactor: clean up docker cmds and improve code blocks #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2024
Merged

refactor: clean up docker cmds and improve code blocks #2041

merged 2 commits into from
Nov 21, 2024

Conversation

vinceAmstoutz
Copy link
Member

@vinceAmstoutz vinceAmstoutz commented Oct 17, 2024 •
edited
Loading

Partially solves #1995 by solving these 2 subtasks :

  • "Remove all docker compose prefixes for commands, as we don't use Docker for Laravel"
  • "Explain how to run commands with Symfony and Docker in the symfony/index.md"

⚠️ Don't forget to check the checkbox in the issue if the PR is merged

@vinceAmstoutz vinceAmstoutz requested a review from dunglas October 17, 2024 08:24
@vinceAmstoutz vinceAmstoutz changed the title docs: remove docker compose commands & use bash codeblocks over console docs: remove docker compose commands & improve codeblocks Oct 17, 2024
@vinceAmstoutz vinceAmstoutz force-pushed the docs-remove-docker-compose-prefixes branch from ff4f0b8 to b89b675 Compare October 17, 2024 08:51
dunglas
dunglas requested changes Oct 23, 2024
View reviewed changes
@vinceAmstoutz vinceAmstoutz force-pushed the docs-remove-docker-compose-prefixes branch from b89b675 to cb02ffd Compare October 23, 2024 15:40
@vinceAmstoutz vinceAmstoutz requested a review from dunglas October 23, 2024 15:51
alanpoulain
alanpoulain reviewed Nov 21, 2024
View reviewed changes
alanpoulain
alanpoulain reviewed Nov 21, 2024
View reviewed changes
alanpoulain
alanpoulain reviewed Nov 21, 2024
View reviewed changes
@vinceAmstoutz vinceAmstoutz force-pushed the docs-remove-docker-compose-prefixes branch from cb02ffd to 513b3c3 Compare November 21, 2024 12:52
@vinceAmstoutz vinceAmstoutz changed the title docs: remove docker compose commands & improve codeblocks docs: clean up docker compose cmds and improve code blocks Nov 21, 2024
@vinceAmstoutz vinceAmstoutz changed the title docs: clean up docker compose cmds and improve code blocks refactor: clean up docker compose cmds and improve code blocks Nov 21, 2024
@vinceAmstoutz vinceAmstoutz changed the title refactor: clean up docker compose cmds and improve code blocks refactor: clean up docker cmds and improve code blocks Nov 21, 2024
@alanpoulain alanpoulain merged commit de4ec84 into api-platform:4.0 Nov 21, 2024
1 check passed
@vinceAmstoutz vinceAmstoutz deleted the docs-remove-docker-compose-prefixes branch November 21, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanpoulain alanpoulain alanpoulain approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@soyuka soyuka Awaiting requested review from soyuka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinceAmstoutz @dunglas @alanpoulain