Doctrine ORM Filters - service declaration #440
Conversation
core/filters.md
Outdated
| @@ -30,12 +30,28 @@ services: | |||
| arguments: [ { dateProperty: ~ } ] | |||
| tags: [ 'api_platform.filter' ] | |||
| # The following are mandatory only if a _defaults section is defined | |||
| # You may want to isolate filters in a dedicated file to avoid adding them | |||
There was a problem hiding this comment.
Ok for the see, but I'll keep the comment about a dedicated file (it's a a good practice in large apps)
There was a problem hiding this comment.
I've added that point just after with a dedicated example (l.39), but maybe this is too much information? If not, we may add the comment that it's a good practice in large apps.
core/filters.md
Outdated
| services: | ||
| _defaults: | ||
| autowire: false | ||
| autoconfigure: false |
There was a problem hiding this comment.
With autoconfigure true you could remove the tag in the declaration isn't it ?
There was a problem hiding this comment.
As it was specified in the doc to "false" and I'm not familiar enough with apiplatform, i've let the default parameter. What does the apiplatform team think?
There was a problem hiding this comment.
This is the default in a new file, so you can just remove the whole _defaults block here.
core/filters.md
Outdated
| services: | ||
| _defaults: | ||
| autowire: false | ||
| autoconfigure: false |
There was a problem hiding this comment.
This is the default in a new file, so you can just remove the whole _defaults block here.
alanpoulain
force-pushed
the
filters
branch
from
46718d9 to
5f12481
Compare
alanpoulain
force-pushed
the
filters
branch
from
5f12481 to
f32b011
Compare
alanpoulain
force-pushed
the
filters
branch
from
f32b011 to
04f4c14
Compare
Hi,
This is a proposal to clarify a point with the service declaration and the _defaults section, which may not make perfect sense for newcomers.