“Schema generator“ > improve “Getting started” #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexislefebvre
changed the title
dunglas
approved these changes
Mar 20, 2018
added 2 commits
March 20, 2018 17:25
alexislefebvre
force-pushed
the
442-schema-generator-improve-getting-started
branch
from
696a586 to
e3a2960
Compare
| telephone: ~ | ||
| email: ~ | ||
| url: ~ | ||
| jobTitle: ~ |
There was a problem hiding this comment.
Maybe I missed something but why do you remove these properties?
There was a problem hiding this comment.
I think that we don't need 10 properties in order to understand this code sample. It makes the generated code longer and it adds no value.
meyerbaptiste
approved these changes
Mar 21, 2018
|
Thanks @alexislefebvre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #442