Skip to content

Fix documentation for custom operation configuration #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2018
Merged

Fix documentation for custom operation configuration #448

merged 1 commit into from
Mar 23, 2018

Conversation

jonag
Copy link
Contributor

@jonag jonag commented Mar 23, 2018

While trying the recommended custom operation configuration from the documentation, I found out that the attribute method seems to be mandatory.

@dunglas dunglas merged commit 7100e39 into api-platform:2.2 Mar 23, 2018
@dunglas
Copy link
Member

dunglas commented Mar 23, 2018

Thanks @jonag.

We could default to GET if controller is set, WDYT @meyerbaptiste?

@meyerbaptiste
Copy link
Member

Yes, I thought the same thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyerbaptiste meyerbaptiste meyerbaptiste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonag @dunglas @meyerbaptiste