[Core/Serialization] Use correct ContextAwareNormalizerInterface #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to : https://github.com/api-platform/docs/blob/2.2/core/serialization.md#changing-the-serialization-context-on-a-per-item-basis The class used in custom normalization example implements `NormalizerInterface` but the `supportsNormalization()` method is the one from the `ContextAwareNormalizerInterface`, and it must be this one to access `$context` variable and avoid call loops.
|
Good catch, thanks @paxal |
|
Thanks for this awesome documentation :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to : https://github.com/api-platform/docs/blob/2.2/core/serialization.md#changing-the-serialization-context-on-a-per-item-basis
The class used in custom normalization example implements
NormalizerInterfacebut thesupportsNormalization()method is the one from theContextAwareNormalizerInterface, and it must be this one to access$contextvariable and avoid call loops.This doc is very valuable, thanks !