Skip to content

Document deprecations #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2018
Merged

Document deprecations #656

merged 1 commit into from
Nov 15, 2018

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Nov 14, 2018

antograssiot
antograssiot reviewed Nov 14, 2018
View reviewed changes
Copy link
Contributor

@antograssiot antograssiot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Shouldn't the file be included in the TOC tree somewhere though ?

@dunglas
Copy link
Member Author

dunglas commented Nov 14, 2018

It's automatic now. It should just be added in https://github.com/api-platform/website/blob/master/config/outline.yaml after the merge (it could be nice to move this file in this repo btw).

@dunglas dunglas merged commit e2c81a9 into api-platform:2.3 Nov 15, 2018
@dunglas dunglas deleted the deprecation branch November 15, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@antograssiot antograssiot antograssiot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dunglas @antograssiot