Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override functions documentation #765

Merged
merged 1 commit into from Apr 7, 2019

Conversation

Projects
None yet
4 participants
@jfthuillier
Copy link
Contributor

jfthuillier commented Mar 18, 2019

No description provided.

@dunglas
Copy link
Member

dunglas left a comment

Great addition

Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated

@jfthuillier jfthuillier force-pushed the jfthuillier:admin-customizing branch 2 times, most recently from c6017fd to db43c06 Mar 20, 2019

@jfthuillier

This comment has been minimized.

Copy link
Contributor Author

jfthuillier commented Mar 20, 2019

Done, thanks for your review 👍

Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated

@jfthuillier jfthuillier force-pushed the jfthuillier:admin-customizing branch from db43c06 to 02d715c Apr 6, 2019

Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
@dunglas

This comment has been minimized.

Copy link
Member

dunglas commented Apr 6, 2019

If we replace this feature soon by react-admin guessers, maybe doesn’t it worth it to document it fully?

@alanpoulain

This comment has been minimized.

Copy link
Member

alanpoulain commented Apr 6, 2019

@dunglas I think it's worth it in the meantime. Also, are we sure we want to use the guessers? Is it really an improvement?

@dunglas

This comment has been minimized.

Copy link
Member

dunglas commented Apr 6, 2019

AFAIU how guessers work, it is: the user will just be able to copy/paste the content of its dev console and then everything can be customized “as usual” when working with React-Admin. It will be a great DX improvement.

We can document it in the meantime of course, but don’t invest to much time in this docs if we remove these functions soon.

@jfthuillier jfthuillier force-pushed the jfthuillier:admin-customizing branch from 02d715c to e67cefa Apr 6, 2019

Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
Show resolved Hide resolved admin/customizing.md Outdated
JF

@jfthuillier jfthuillier force-pushed the jfthuillier:admin-customizing branch from e67cefa to 8bfd7b9 Apr 7, 2019

@alanpoulain alanpoulain merged commit 54cb765 into api-platform:2.4 Apr 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alanpoulain

This comment has been minimized.

Copy link
Member

alanpoulain commented Apr 7, 2019

Thank you @jfthuillier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.