Override functions documentation #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfthuillier
force-pushed
the
admin-customizing
branch
2 times, most recently
from
c6017fd
to
db43c06
Compare
|
Done, thanks for your review 👍 |
alanpoulain
reviewed
Mar 21, 2019
alanpoulain
reviewed
Mar 21, 2019
alanpoulain
reviewed
Mar 21, 2019
alanpoulain
reviewed
Mar 21, 2019
alanpoulain
reviewed
Mar 21, 2019
alanpoulain
reviewed
Mar 21, 2019
alanpoulain
reviewed
Mar 21, 2019
alanpoulain
reviewed
Mar 21, 2019
alanpoulain
reviewed
Mar 21, 2019
alanpoulain
reviewed
Mar 21, 2019
alanpoulain
reviewed
Mar 21, 2019
alanpoulain
reviewed
Mar 21, 2019
alanpoulain
reviewed
Mar 21, 2019
alanpoulain
reviewed
Mar 21, 2019
jfthuillier
force-pushed
the
admin-customizing
branch
from
db43c06
to
02d715c
Compare
alanpoulain
reviewed
Apr 6, 2019
alanpoulain
reviewed
Apr 6, 2019
alanpoulain
reviewed
Apr 6, 2019
alanpoulain
reviewed
Apr 6, 2019
alanpoulain
reviewed
Apr 6, 2019
|
If we replace this feature soon by react-admin guessers, maybe doesn’t it worth it to document it fully? |
|
@dunglas I think it's worth it in the meantime. Also, are we sure we want to use the guessers? Is it really an improvement? |
|
AFAIU how guessers work, it is: the user will just be able to copy/paste the content of its dev console and then everything can be customized “as usual” when working with React-Admin. It will be a great DX improvement. We can document it in the meantime of course, but don’t invest to much time in this docs if we remove these functions soon. |
jfthuillier
force-pushed
the
admin-customizing
branch
from
02d715c
to
e67cefa
Compare
alanpoulain
reviewed
Apr 7, 2019
alanpoulain
reviewed
Apr 7, 2019
alanpoulain
reviewed
Apr 7, 2019
alanpoulain
reviewed
Apr 7, 2019
jfthuillier
force-pushed
the
admin-customizing
branch
from
e67cefa
to
8bfd7b9
Compare
alanpoulain
approved these changes
Apr 7, 2019
|
Thank you @jfthuillier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.