Skip to content

Reduce visibility of FOSUserBundle #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2019
Merged

Reduce visibility of FOSUserBundle #838

merged 1 commit into from
Sep 24, 2019
+0 −1

Conversation

teohhanhui
Copy link
Contributor

Don't promote it

@teohhanhui teohhanhui requested a review from dunglas June 20, 2019 10:22
@dunglas
Copy link
Member

dunglas commented Jun 21, 2019

I would prefer to add a warning on the FOSUser integration page than removing this link.

@teohhanhui
Copy link
Contributor Author

I think it's bad to highlight it as one of the "features" of API Platform.

@teohhanhui
Copy link
Contributor Author

Maybe we can move it further down the page?

@teohhanhui
Copy link
Contributor Author

For example, we don't mention NelmioApiDocBundle integration as a feature. We should give FOSUserBundle the same treatment.

@dunglas dunglas merged commit 2cb4e86 into 2.4 Sep 24, 2019
@dunglas dunglas deleted the dont-promote-fosuserbundle branch September 24, 2019 19:34
@dunglas
Copy link
Member

dunglas commented Sep 24, 2019

Thanks @teohhanhui. It will still appear in the menu so it's good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teohhanhui @dunglas