Entities have some properties and methods generated twise

[hollax]

Some of the entities have some properties and methods generated twice. What am i doing wrong?
i used allProperties: true in the configuration for these entities

[stefann-sasori]

Same here. Any helps ?

[stefann-sasori]

Hello,

I found that this issue occurs when an entity has both a plural and singular form of a given property.
For example: Cemetery has these properties:

• event
• events (superseded by event)

or

• map
• maps (superseded by map)

Both of such properties are generated by the generator.
However: all non array property names are singularized before the generation

schema-generator/src/TypesGenerator.php

Line 651 in 14c4e2e

'name' => $isArray ? Inflector::pluralize($propertyName) : Inflector::singularize($propertyName),

so that in the case of the Cemetery entity:

• "events" will be transformed to "event" causing the duplication of the "event" property.

As I assume that it makes sense to "pluralize" an array property, I wonder why it is necessary to "singularize" all the non array properties.
Many string properties in schema.org are written with a plural form when they are meant to contain multiple values separated by a comma within a string. These are for example: https://schema.org/keywords, https://schema.org/maps ...

It seemed to work when I fixed it this way:

Thanks you guys for this handy tool 👍 !

[dunglas]

Closed by #153