Singularize/pluralize 3+ letter long words only in the property names #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deuchnord
force-pushed
the
do-not-singularize-two-letter-words
branch
from
cf9de06 to
978f9a7
Compare
|
Shouldn't this be fixed in the Inflector library directly? |
|
I actually wondered the same question, but the Inflector library singularizes/pluralizes single nouns only. Here, we use it to do the same on properties eventually named with several words, so it seemed to me the change was to be done here. |
Deuchnord
force-pushed
the
do-not-singularize-two-letter-words
branch
from
978f9a7 to
269cce0
Compare
|
linting |
Deuchnord
force-pushed
the
do-not-singularize-two-letter-words
branch
from
269cce0 to
1a2db3c
Compare
Deuchnord
force-pushed
the
do-not-singularize-two-letter-words
branch
from
1a2db3c to
25318e5
Compare
dunglas
approved these changes
Jan 10, 2020
|
Thanks @Deuchnord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue that makes some words in property names being singularized/pluralized, when they actually are not nouns (e.g., same as in the Thing schema should not be singularized in same a).
To fix this, we separate the words in the property name and check that the last word is more than 2 letter long [1]. If it is, then it is singularized/pluralized, otherwise it remains as is. The rest is left unchanged.
[1]: in English, two-letter long words are in majority acronyms, and the rest are not nouns. See https://en.wikibooks.org/wiki/Scrabble/Two_Letter_Words