Add a readable and a writable config option for fields #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
approved these changes
Sep 6, 2017
toofff
approved these changes
Sep 6, 2017
| $this->assertEquals(0, $commandTester->execute(['output' => $outputDir, 'config' => $config])); | ||
| $person = file_get_contents($outputDir.'/AppBundle/Entity/Person.php'); | ||
|
|
||
| $person = file_get_contents($outputDir.'/AppBundle/Entity/Person.php'); |
There was a problem hiding this comment.
question : Why concatenation here instead of sprintf method ?
There was a problem hiding this comment.
Because it's already easy to read and it's faster (even if it doesn't matter much in a test). The fastest solution in PHP 7 would be file_get_contents("$outputDir/AppBundle/Entity/Person.php");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
readableis set tofalse, the getter will not be generated. Ifwritableis set to false, the mutator will not be generated.