Removes dappId from adapter contracts #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
approved these changes
Sep 29, 2025
| revert("Mock: Not implemented"); | ||
| } | ||
|
|
||
| function dappId() external pure override returns (uint256) { |
There was a problem hiding this comment.
Mhh, it's strange to see it implemented like this 🤔 Why not omit?
There was a problem hiding this comment.
We can't omit it because it is required by the IApi3ReaderProxyV1 interface but think of it as a safety measure where reverting immediately flags any unexpected use of the function during testing, which prevents bugs that might otherwise go unnoticed if we instead return some dummy value
|
|
||
| let dappId2; | ||
| if (!isLocalNetwork) { | ||
| let dappId1, dappId2; |
There was a problem hiding this comment.
Why do we use the !isLocalNetwork above?
There was a problem hiding this comment.
There's no need to check for dappId equality locally (NETWORK=hardhat) because the script uses mock proxies for testing
acenolaza
force-pushed
the
39-removes-dappid-from-adapters
branch
from
4bb16bb to
6ea628c
Compare
acenolaza
force-pushed
the
39-removes-dappid-from-adapters
branch
from
6ea628c to
154359b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39
Implementation details
dappIdfrom adapter contractsIApi3ReaderProxycompliantIApi3ReaderProxyV1compliant and dappIds don't matchNow we should be able to deploy a ProductApi3ReaderProxyV1 composing wstETH exchange rate with ETH/USD feed since
dappIdwill no longer be checked onchain nor during deployment but in cases where both proxies have dappIds then the deploy script will make sure they are equal.