Skip to content

feat(core): sort the configuration by readable name during dump #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

feat(core): sort the configuration by readable name during dump #260

merged 1 commit into from
Apr 24, 2025

Conversation

bzp2010
Copy link
Collaborator

@bzp2010 bzp2010 commented Apr 24, 2025

Description

  1. Ensure that the username in the consumer is always displayed before the plugins
  2. Ensure that each resource is sorted using its unique readable name, e.g., name, username, etc.

Improved comparability when exporting multiple times.

Fix #259

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible

@juzhiyuan
Copy link
Contributor

LGTM

@bzp2010 bzp2010 merged commit 1189c43 into main Apr 24, 2025
16 checks passed
@bzp2010 bzp2010 deleted the bzp/fix-consumer-dump-sort branch April 24, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@SkyeYoung SkyeYoung Awaiting requested review from SkyeYoung

@guoqqqi guoqqqi Awaiting requested review from guoqqqi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: resource dumps not sorted by readable name as expected
2 participants
@bzp2010 @juzhiyuan