Skip to content

feat: support apisix tls #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 20, 2025
Merged

feat: support apisix tls #171

merged 11 commits into from
Jun 20, 2025

Conversation

ronething
Copy link
Contributor

@ronething ronething commented Jun 19, 2025

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: ashing <axingfly@gmail.com>
@ronething ronething marked this pull request as draft June 19, 2025 03:39
Signed-off-by: ashing <axingfly@gmail.com>
Copy link

github-actions bot commented Jun 19, 2025

conformance test report

apiVersion: gateway.networking.k8s.io/v1
date: "2025-06-20T03:34:27Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
  contact: null
  organization: APISIX
  project: apisix-ingress-controller
  url: https://github.com/apache/apisix-ingress-controller.git
  version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
    result: partial
    skippedTests:
    - HTTPRouteHTTPSListener
    statistics:
      Failed: 0
      Passed: 32
      Skipped: 1
  name: GATEWAY-HTTP
  summary: Core tests partially succeeded with 1 test skips.

Copy link

github-actions bot commented Jun 19, 2025

conformance test report

apiVersion: gateway.networking.k8s.io/v1
date: "2025-06-20T03:31:25Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
  contact: null
  organization: APISIX
  project: apisix-ingress-controller
  url: https://github.com/apache/apisix-ingress-controller.git
  version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
    result: partial
    skippedTests:
    - HTTPRouteHTTPSListener
    statistics:
      Failed: 0
      Passed: 32
      Skipped: 1
  name: GATEWAY-HTTP
  summary: Core tests partially succeeded with 1 test skips.

Signed-off-by: ashing <axingfly@gmail.com>
Signed-off-by: ashing <axingfly@gmail.com>
Signed-off-by: ashing <axingfly@gmail.com>
Signed-off-by: ashing <axingfly@gmail.com>
…t_apisixtls

Signed-off-by: ashing <axingfly@gmail.com>
Signed-off-by: ashing <axingfly@gmail.com>
Signed-off-by: ashing <axingfly@gmail.com>
@ronething ronething changed the title (WIP) feat: support apisix tls feat: support apisix tls Jun 19, 2025
@ronething ronething marked this pull request as ready for review June 19, 2025 13:05
Signed-off-by: ashing <axingfly@gmail.com>
@ronething ronething requested a review from Copilot June 20, 2025 02:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds full support for the ApisixTls CR, including e2e tests, provider translation, controller wiring, indexing, and sample YAML updates.

  • Introduces end-to-end tests for TLS and mTLS in test/e2e/apisix/tls.go
  • Implements translation of ApisixTls CR to ADC SSL resources and registers it in the ADC client
  • Wires up ApisixTls in the controller manager, indexing, and updates sample manifests for v2 and adds an ApisixTls example

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/e2e/apisix/tls.go Add e2e tests covering basic TLS and mutual TLS scenarios
internal/provider/adc/translator/apisixtls.go Implement TranslateApisixTls to generate ADC SSL objects
internal/provider/adc/adc.go Register ApisixTls handling in ADC client's Update and Delete
internal/manager/controllers.go Add ApisixTlsReconciler to controller setup
internal/controller/utils.go Define KindApisixTls constant
internal/controller/indexer/indexer.go Add field indexers for ApisixTls secrets and ingress class references
config/samples/* Update sample CRDs to apiVersion: apisix.apache.org/v2 and add ApisixTls sample
Comments suppressed due to low confidence (2)

config/samples/apisix.apache.org_v2_apisixupstream.yaml:1

  • Sample CR files in this directory use a leading dash to form a list in Kustomize. The leading - was removed here, which may break sample bundling. Re-add the dash before apiVersion to maintain the list format.
apiVersion: apisix.apache.org/v2

config/samples/apisix.apache.org_v2_apisixtls.yaml:1

  • This new sample should follow the existing pattern of a leading - to be included as a list item in Kustomize. Add - before apiVersion.
apiVersion: apisix.apache.org/v2

Signed-off-by: ashing <axingfly@gmail.com>
@ronething ronething merged commit 9694400 into release-v2-dev Jun 20, 2025
14 of 15 checks passed
@ronething ronething deleted the feat/support_apisixtls branch June 23, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants