Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CR to multipart requests based on multipart content-type header, ... #148

Merged
merged 2 commits into from
Feb 17, 2015

Conversation

netmilk
Copy link
Contributor

@netmilk netmilk commented Feb 16, 2015

...Closes #74 #118 #29

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 95.81% when pulling c373e79 on netmilk/multipart into fe6f186 on master.

caseInsensitiveRequestHeaders = {}
for key, value of requestOptions.headers
caseInsensitiveRequestHeaders[key.toLowerCase()] = value
caseInsensitiveRequestHeaders['content-type']?.indexOf("multipart") > -1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to use https://www.npmjs.com/package/caseless here.

caseless(requestOptions.headers).get('content-type')?.indexOf('multipart') > -1 ... but I can see we might refactor more parts of it soon.

kuba-kubula added a commit that referenced this pull request Feb 17, 2015
Adding CR to multipart requests based on multipart content-type header, ...
@kuba-kubula kuba-kubula merged commit e06909d into master Feb 17, 2015
@kuba-kubula kuba-kubula deleted the netmilk/multipart branch February 17, 2015 14:59
artem-zakharchenko pushed a commit that referenced this pull request Oct 9, 2019
Bump uri-template and remove babel-polyfill
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multipart form requests need to use \r\n instead of only \n
3 participants