Feature: Custom user assertions in hooks to fail a transaction #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 20, 2015 12:48
…incompatible with sinon's stubs
|
|
||
| it 'should run all hooks', (done) -> | ||
| runner.executeAllTransactions [transaction], hooksStub, () -> | ||
| assert.ok loggerStub.info.calledWith "first" |
There was a problem hiding this comment.
you are not checking order of calls.
I'd vote to use loggerStub.info.firstCall.calledWith 'first'or similar.
netmilk
changed the title
kuba-kubula
added a commit
that referenced
this pull request
Feb 27, 2015
…matically Feature: Custom user assertions in hooks to fail a transaction
artem-zakharchenko
pushed a commit
that referenced
this pull request
Oct 9, 2019
…r-0.18.0 Update fury-adapter-swagger to version 0.18.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
advisablein hook's infrastructure, it does not work withsinonchai