This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
Remove some more usage of coffeescript #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realityking
force-pushed
the
excise-coffeescript-1
branch
from
f0525a7
to
5ea18d4
Compare
|
Not sure why this has failed on Windows. Maybe someone could restart it to see if it was a fluke? |
|
@realityking Thanks! I retried the build yesterday and it passed. It's flaky. |
honzajavorek
approved these changes
Mar 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Why this change?
Slowly getting rid of some of the remaining references to coffeescript. This is just the first PR but the desired end result should be that it's only used for coffeescript hooks and nothing else.
📝 Related issues and Pull Requests
✅ What didn't I forget?
npm run lint