Skip to content

Conversation

protoss70
Copy link
Contributor

Added new sorting param sortBy for the new feature described in this Issue

I will wait until Apify-Core PR is deployed and then will merge this.

One note, I am not sure if I added the sortBy parameter correctly. Example code below:
return await self._list(my=my, limit=limit, offset=offset, desc=desc, sortBy=sort_by)
I tried to follow similar examples with a camel case api parameter. Please let me know if this is not the correct syntax.

@protoss70 protoss70 requested review from tobice and vdusek June 16, 2025 13:07
@protoss70 protoss70 added the t-integrations Issues with this label are in the ownership of the integrations team. label Jun 16, 2025
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙂 , just one note regarding the docstrings.

@protoss70 protoss70 requested a review from vdusek June 17, 2025 09:23
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@protoss70 protoss70 merged commit df6e47d into master Jun 18, 2025
28 checks passed
@protoss70 protoss70 deleted the feature/new-sorting-param-sortBy branch June 18, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-integrations Issues with this label are in the ownership of the integrations team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants