Skip to content

feat: Expose apify_client.errors module #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2025
Merged

feat: Expose apify_client.errors module #468

merged 3 commits into from
Aug 13, 2025

Conversation

Mantisus
Copy link
Collaborator

  • Move apify_client._errors to apify_client.errors

Issues

@Mantisus Mantisus requested review from vdusek and Pijukatel August 13, 2025 09:14
@Mantisus Mantisus self-assigned this Aug 13, 2025
@Mantisus Mantisus had a problem deploying to fork-pr-integration-tests August 13, 2025 09:15 — with GitHub Actions Failure
@vdusek vdusek changed the title refactor!: Move apify_client._errors to apify_client.errors feat: Expose apify_client.errors module Aug 13, 2025
vdusek
vdusek requested changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but please let's move is_retryable_error function to _utils as this should probably stay private.

@Mantisus Mantisus requested a review from vdusek August 13, 2025 09:37
vdusek
vdusek requested changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what about httpx here? I believe it should be impit and its errors.

@Mantisus Mantisus had a problem deploying to fork-pr-integration-tests August 13, 2025 11:33 — with GitHub Actions Failure
@Mantisus
Copy link
Collaborator Author

Also, what about httpx here? I believe it should be impit and its errors.

That's right, but when I was preparing the PR, we hadn't merged the PR with impit yet. Updated :)

vdusek
vdusek approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit c0cc147 into apify:master Aug 13, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

@Pijukatel Pijukatel Awaiting requested review from Pijukatel

Assignees

@Mantisus Mantisus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move apify_client._errors to apify_client.errors
2 participants
@Mantisus @vdusek