Skip to content

Conversation

vladfrangu
Copy link
Member

@vladfrangu vladfrangu commented Aug 20, 2025

@vladfrangu vladfrangu requested a review from TC-MO as a code owner August 20, 2025 18:18
Copy link

cursor bot commented Aug 20, 2025

🚨 Bugbot Trial Expired

Your team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot.

A team admin can activate the plan in the Cursor dashboard.

@github-actions github-actions bot added this to the 121st sprint - Tooling team milestone Aug 20, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Aug 20, 2025
@vladfrangu vladfrangu added the adhoc Ad-hoc unplanned task added during the sprint. label Aug 20, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit ac74fdb and is ready at https://pr-1817.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit ac630c2 and is ready at https://pr-1817.preview.docs.apify.com!

@patrikbraborec
Copy link
Contributor

It feels for me that the page should be under troubleshooting, or somewhere else. Exactly under /development feels weird, but this is just my opinion...

@vladfrangu
Copy link
Member Author

I don't know exactly where to add it in considering its half changelog half "hey btw changes to docker images happened"

@TC-MO
Copy link
Contributor

TC-MO commented Aug 21, 2025

I'm not sure even if this should be a separate page and not just part of docker.md, let me dive in later in the afternoon into that to find best place & fix prose

@TC-MO
Copy link
Contributor

TC-MO commented Aug 21, 2025

I took some time to delve deeper into it and I believe it should be part of docker.md I have changes prepared that will:

  • move the content
  • adjust it to fit our style guide
  • get rid of time anchor
  • fix lint

if you don't mind I can just push them and we can discuss if they are satisfactory

@vladfrangu
Copy link
Member Author

vladfrangu commented Aug 21, 2025 via email

TC-MO added 2 commits August 22, 2025 00:24
fix prose for clarity & conciseness
change admonition title
remove time anchor
change headings
@apify-service-account
Copy link

Preview for this PR was built for commit c60e17b5 and is ready at https://pr-1817.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit de6bb500 and is ready at https://pr-1817.preview.docs.apify.com!

@TC-MO
Copy link
Contributor

TC-MO commented Aug 21, 2025

Donezo, again this is just my interpretation of what makes most sense from TW POV. I'm open to all discussions :) worst case we revert these changes and look for another approach

Copy link
Member Author

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TC-MO not sure how I feel about having this as crammed into the main dockerfile document but 🤷 see what @patrikbraborec and @B4nan think about it.

But these small changes I'd want applied, thoughts?


:::danger Action required

The base Docker images display a deprecation warning. This warning will be removed in future versions, so you should update your Dockerfiles to ensure forward compatibility.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not a future version, I'll be dropping the warning in Q1 2026!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to avoid anchoring in time, but I think it might be unavoidable, we can add specific

Suggested change
The base Docker images display a deprecation warning. This warning will be removed in future versions, so you should update your Dockerfiles to ensure forward compatibility.
The base Docker images display a deprecation warning. This warning will be removed in Q1 2026, so you should update your Dockerfiles to ensure forward compatibility.

And then make a note in calendar to remove the whole admonition after we drop the warning. Would that work for you?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@patrikbraborec
Copy link
Contributor

I think it is better to have with existing docker docs. I checked it, and it looks good imho. If it gets complicated, we can always separate it, but I would definitely keep it in Actor definition section.

Co-authored-by: Vlad Frangu <me@vladfrangu.dev>
Copy link

cursor bot commented Aug 22, 2025

🚨 Bugbot Trial Expired

Your team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot.

A team admin can activate the plan in the Cursor dashboard.

@apify-service-account
Copy link

Preview for this PR was built for commit 835df6f6 and is ready at https://pr-1817.preview.docs.apify.com!

@B4nan
Copy link
Member

B4nan commented Aug 22, 2025

Same here, I think it's fine on a single page.

Would be good to mention a date of the change too, so people can understand what "older dockerfile" means in this context.

@TC-MO
Copy link
Contributor

TC-MO commented Aug 22, 2025

I'll add specific time (Q1 2026) to the admonition, tho if we can settle on specific date @vladfrangu that would be preferable, then we can setup reminder to remove it past that date

@vladfrangu
Copy link
Member Author

I'll add specific time (Q1 2026) to the admonition, tho if we can settle on specific date @vladfrangu that would be preferable, then we can setup reminder to remove it past that date

I want to do the actual release Monday, sooo... I guess thats the date?

@vladfrangu
Copy link
Member Author

Or do you mean a date when the warning drops? I mean realistically speaking when I say Q1 i mean probably mid january, or start of february, to give people 6 months to fix their images

@B4nan
Copy link
Member

B4nan commented Aug 22, 2025

I meant the date when we change the logic, not when we remove the warning.

@vladfrangu
Copy link
Member Author

Then next monday it is!

@TC-MO
Copy link
Contributor

TC-MO commented Aug 22, 2025

Oh and I meant the day we drop the warning :D For the date of change we can reprhase the warning to state:

:::danger Action required

As of here the date the base Docker images display a deprecation warning. This warning will be removed in Q1 2026 (or specific date), so you should update your Dockerfiles to ensure forward compatibility.

:::

Copy link

cursor bot commented Aug 25, 2025

🚨 Bugbot Trial Expired

Your team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot.

A team admin can activate the plan in the Cursor dashboard.

@apify-service-account
Copy link

Preview for this PR was built for commit 616cc208 and is ready at https://pr-1817.preview.docs.apify.com!

@vladfrangu vladfrangu merged commit 46a628f into master Aug 25, 2025
10 checks passed
@vladfrangu vladfrangu deleted the docs/priviledge-less-docker-image-move branch August 25, 2025 10:52
daveomri pushed a commit to daveomri/apify-docs that referenced this pull request Sep 3, 2025
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants