-
Notifications
You must be signed in to change notification settings - Fork 128
docs: upgrades for privilege-less Docker images #1817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚨 Bugbot Trial ExpiredYour team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot. A team admin can activate the plan in the Cursor dashboard. |
Preview for this PR was built for commit |
Preview for this PR was built for commit |
It feels for me that the page should be under troubleshooting, or somewhere else. Exactly under /development feels weird, but this is just my opinion... |
I don't know exactly where to add it in considering its half changelog half "hey btw changes to docker images happened" |
I'm not sure even if this should be a separate page and not just part of docker.md, let me dive in later in the afternoon into that to find best place & fix prose |
I took some time to delve deeper into it and I believe it should be part of
if you don't mind I can just push them and we can discuss if they are satisfactory |
Do them as you wish, we can discuss tomorrow! But keep in mind I wanted to make it a separate page, and I'm not sure if cramming it into the existing page is smart 😅
…On Aug 22, 2025 at 00:54 +0300, Michał Olender ***@***.***>, wrote:
TC-MO left a comment (apify/apify-docs#1817)
I took some time to delve deeper into it and I believe it should be part of docker.md I have changes prepared that will:
• move the content
• adjust it to fit our style guide
• get rid of time anchor
• fix lint
if you don't mind I can just push them and we can discuss if they are satisfactory
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
fix prose for clarity & conciseness change admonition title remove time anchor change headings
Preview for this PR was built for commit |
Preview for this PR was built for commit |
Donezo, again this is just my interpretation of what makes most sense from TW POV. I'm open to all discussions :) worst case we revert these changes and look for another approach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TC-MO not sure how I feel about having this as crammed into the main dockerfile document but 🤷 see what @patrikbraborec and @B4nan think about it.
But these small changes I'd want applied, thoughts?
|
||
:::danger Action required | ||
|
||
The base Docker images display a deprecation warning. This warning will be removed in future versions, so you should update your Dockerfiles to ensure forward compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not a future version, I'll be dropping the warning in Q1 2026!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to avoid anchoring in time, but I think it might be unavoidable, we can add specific
The base Docker images display a deprecation warning. This warning will be removed in future versions, so you should update your Dockerfiles to ensure forward compatibility. | |
The base Docker images display a deprecation warning. This warning will be removed in Q1 2026, so you should update your Dockerfiles to ensure forward compatibility. |
And then make a note in calendar to remove the whole admonition after we drop the warning. Would that work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
I think it is better to have with existing docker docs. I checked it, and it looks good imho. If it gets complicated, we can always separate it, but I would definitely keep it in |
Co-authored-by: Vlad Frangu <me@vladfrangu.dev>
🚨 Bugbot Trial ExpiredYour team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot. A team admin can activate the plan in the Cursor dashboard. |
Preview for this PR was built for commit |
Same here, I think it's fine on a single page. Would be good to mention a date of the change too, so people can understand what "older dockerfile" means in this context. |
I'll add specific time (Q1 2026) to the admonition, tho if we can settle on specific date @vladfrangu that would be preferable, then we can setup reminder to remove it past that date |
I want to do the actual release Monday, sooo... I guess thats the date? |
Or do you mean a date when the warning drops? I mean realistically speaking when I say Q1 i mean probably mid january, or start of february, to give people 6 months to fix their images |
I meant the date when we change the logic, not when we remove the warning. |
Then next monday it is! |
Oh and I meant the day we drop the warning :D For the date of change we can reprhase the warning to state: :::danger Action required As of ::: |
🚨 Bugbot Trial ExpiredYour team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot. A team admin can activate the plan in the Cursor dashboard. |
Preview for this PR was built for commit |
Co-authored-by: Michał Olender <92638966+TC-MO@users.noreply.github.com>
Related to apify/apify-actor-docker#188
https://pr-1817.preview.docs.apify.com/platform/actors/development/docker-user-changes