Skip to content

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Aug 25, 2025

Recent lychee updates (0.19.0 and above) improve Lychee and align it more with the HTML spec. This, however, also means that Lychee now finds 2000+ "broken" links due to incorrect setup in this repo.

Since fragment links inside of docs.apify.com are checked internally with Docusaurus anyway, this PR disables the fragment link checker in Lychee.

@barjin barjin self-assigned this Aug 25, 2025
@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Aug 25, 2025
@github-actions github-actions bot added this to the 122nd sprint - Tooling team milestone Aug 25, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Aug 25, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit 7891fa27 and is ready at https://pr-1839.preview.docs.apify.com!

@barjin
Copy link
Contributor Author

barjin commented Aug 25, 2025

Example run here:

https://github.com/apify/apify-docs/actions/runs/17211763113/job/48825140318

imo all the reported errors are relevant.

@barjin barjin requested a review from TC-MO August 25, 2025 14:35
@barjin barjin marked this pull request as ready for review August 25, 2025 14:35
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you, I'll handle all the relevant errors

@barjin barjin merged commit 0f2d0e3 into master Aug 25, 2025
10 checks passed
@barjin barjin deleted the chore/pin-lychee-version branch August 25, 2025 14:38
@apify-service-account
Copy link

Preview for this PR was built for commit 44c9d322 and is ready at https://pr-1839.preview.docs.apify.com!

daveomri pushed a commit to daveomri/apify-docs that referenced this pull request Sep 3, 2025
Recent `lychee` updates (`0.19.0` and above) improve Lychee and align it
more with the HTML spec. This, however, also means that Lychee now finds
2000+ "broken" links due to incorrect setup in this repo.

Since fragment links inside of docs.apify.com are checked internally
with Docusaurus anyway, this PR disables the fragment link checker in
Lychee.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants