Skip to content

feat: use the tip admonition for exercise hints #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

feat: use the tip admonition for exercise hints #1887

merged 2 commits into from
Sep 4, 2025

Conversation

honzajavorek
Copy link
Collaborator

7gbw0x-1966945061

@honzajavorek honzajavorek requested a review from TC-MO September 4, 2025 09:16
@honzajavorek honzajavorek added the t-academy Issues related to Web Scraping and Apify academies. label Sep 4, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit 920efd7 and is ready at https://pr-1887.preview.docs.apify.com!

TC-MO
TC-MO reviewed Sep 4, 2025
View reviewed changes
Copy link
Contributor

@TC-MO TC-MO left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if Hint is the best title. I know it would be a lot of work to title each admonition separately but it doesn't look great to me

image

Thoughts?

EDIT

I can just foresee them skipping over it easily 🤔

@honzajavorek
Copy link
Collaborator Author

I can imagine people skipping over them visually, as sometimes there are two boxes like this (hint and solution) and it might get cluttered... but I don't know how to fight it and if title would be a solution to that. But then, it's only hints, right? 😈

Regarding titles, I can imagine something more creative, but atm I don't know what precisely. One variant would be "Hint: blah blah" so it's consistent, but then I'm not even sure it's worth naming each of them like this. I mean - I don't mind the work, it's just that sometimes the title would be basically already containing the hint as the hint is one link or one sentence 😅

Another variant could be that it's the same text for each of them, but more creative, like invitation, something like "Need a nudge?"

@TC-MO
Copy link
Contributor

TC-MO commented Sep 4, 2025

Ooh tbh I do like more colloquial Need a nudge?

@honzajavorek
Copy link
Collaborator Author

As I wrote it down I fell in love with it. Let's do it! Need a nudge? for everyone!

@apify-service-account
Copy link

Preview for this PR was built for commit 1eb1b634 and is ready at https://pr-1887.preview.docs.apify.com!

TC-MO
TC-MO approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that works

@honzajavorek honzajavorek merged commit 97b3d99 into master Sep 4, 2025
9 checks passed
@honzajavorek honzajavorek deleted the honzajavorek/hints branch September 4, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TC-MO TC-MO TC-MO approved these changes

Assignees
No one assigned
Labels
t-academy Issues related to Web Scraping and Apify academies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@honzajavorek @apify-service-account @TC-MO