fix: config of ignored contexts and patterns #1901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to my tests, this fixes Vale checking. Current vale.ini disables checking in most of the files, one of the regexes probably being too greedy. Exctracted from #1890 I couldn't confirm that enabling specific Apify rules like ```ini Apify.H1 = YES Apify.Apify = YES Apify.Capitalization = YES Apify.Languages = YES ``` is necessary, Vale seems to pick them up correctly on my machine.
honzajavorek
added
documentation
TC-MO
approved these changes
Sep 8, 2025
|
Preview for this PR was built for commit |
patrikbraborec
pushed a commit
that referenced
this pull request
Sep 10, 2025
According to my tests, this fixes Vale checking. Current `vale.ini` disables checking in most of the files, one of the regexes probably being too greedy. Exctracted from #1890 I couldn't confirm that enabling specific Apify rules like ```ini Apify.H1 = YES Apify.Apify = YES Apify.Capitalization = YES Apify.Languages = YES ``` is necessary, Vale seems to pick them up correctly on my machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my tests, this fixes Vale checking. Current
vale.inidisables checking in most of the files, one of the regexes probably being too greedy. Exctracted from #1890I couldn't confirm that enabling specific Apify rules like
is necessary, Vale seems to pick them up correctly on my machine.