chore: ignore docs quality checks for legal documents #1903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzajavorek
added
documentation
|
Preview for this PR was built for commit |
Merged
|
Preview for this PR was built for commit |
mnmkng
approved these changes
Sep 8, 2025
|
This likely broke all the legal pages, I dont think you can put anything above the frontmatter. The legal page now looks like this: 
|
B4nan
added a commit
that referenced
this pull request
Sep 9, 2025
|
Apologies again, I should have tested it out more thoroughly 🙇♂️ |
patrikbraborec
pushed a commit
that referenced
this pull request
Sep 10, 2025
Extracted from #1890 Context is explained by @TC-MO in this comment: #1890 (comment) > @mnmkng context for you, in `/legal` I moved `<!-- vale off --> comment before frontmantter to not have the new rule targeting H1's affect anything. Also I've added ` I don't think you were using it and it was throwing a lot of false positives when working locally on docs repo. But if you are indeed using it, we can revert this change easily. > > * The goal here is it create new rule for Vale targeting H1's to prevent issues with the LLM buttons > * It also led to issues with the custom rules I've created previously so this PR should fix that > * I also took this opporunity to update the packages for `write-good` & `msoft style guide` that we use in docs
patrikbraborec
pushed a commit
that referenced
this pull request
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1890 Context is explained by @TC-MO in this comment: #1890 (comment)