Skip to content

Conversation

HonzaTuron
Copy link
Contributor

@HonzaTuron HonzaTuron commented Sep 9, 2025

Closes #1870

Descriptions were split in the middle of the sentence as docusaurus took only first line.

This PR introduces splitting by sentence.

Screenshot 2025-09-09 at 16 45 39

@github-actions github-actions bot added this to the 123rd sprint - Web team milestone Sep 9, 2025
@github-actions github-actions bot added the t-web Issues with this label are in the ownership of the web team. label Sep 9, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit 7145f33c and is ready at https://pr-1911.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit fdd7d4f5 and is ready at https://pr-1911.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 48ce8523 and is ready at https://pr-1911.preview.docs.apify.com!

@HonzaTuron HonzaTuron marked this pull request as ready for review September 9, 2025 14:44
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, please have a team admin upgrade your team to Bugbot Pro by visiting the Cursor dashboard. Your first 14 days will be free!

Comment @cursor review or bugbot run to trigger another review on this PR

@apify-service-account
Copy link

Preview for this PR was built for commit 12a6cf0c and is ready at https://pr-1911.preview.docs.apify.com!

@B4nan
Copy link
Member

B4nan commented Sep 10, 2025

Do we want to keep markdown in there? A better/more robust solution would be processing it with some markdown renderer instead of this regexp magic, especially if we want to get rid of the markdown markup too.

@apify-service-account
Copy link

Preview for this PR was built for commit a7ccdd14 and is ready at https://pr-1911.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit def3086e and is ready at https://pr-1911.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 462e9f36 and is ready at https://pr-1911.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 77e2449f and is ready at https://pr-1911.preview.docs.apify.com!

@HonzaTuron
Copy link
Contributor Author

@B4nan I've tried to implement this with remark but there are only some old plugins to sanitize mdx and/or html. Is it fine to use this regex approach?

@apify-service-account
Copy link

Preview for this PR was built for commit ee9dd56e and is ready at https://pr-1911.preview.docs.apify.com!

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, let's not waste too much time on this.

@HonzaTuron HonzaTuron merged commit 4f510f3 into master Sep 17, 2025
9 checks passed
@HonzaTuron HonzaTuron deleted the fix/descriptions branch September 17, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-web Issues with this label are in the ownership of the web team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sub-optimal meta description in API-related pages

3 participants