-
Notifications
You must be signed in to change notification settings - Fork 130
fix: Correct meta descriptions #1911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview for this PR was built for commit |
Preview for this PR was built for commit |
Preview for this PR was built for commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, please have a team admin upgrade your team to Bugbot Pro by visiting the Cursor dashboard. Your first 14 days will be free!
Comment @cursor review
or bugbot run
to trigger another review on this PR
Preview for this PR was built for commit |
Do we want to keep markdown in there? A better/more robust solution would be processing it with some markdown renderer instead of this regexp magic, especially if we want to get rid of the markdown markup too. |
Preview for this PR was built for commit |
Preview for this PR was built for commit |
Preview for this PR was built for commit |
Preview for this PR was built for commit |
@B4nan I've tried to implement this with remark but there are only some old plugins to sanitize mdx and/or html. Is it fine to use this regex approach? |
Preview for this PR was built for commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, let's not waste too much time on this.
Closes #1870
Descriptions were split in the middle of the sentence as docusaurus took only first line.
This PR introduces splitting by sentence.