-
Notifications
You must be signed in to change notification settings - Fork 129
feat(docs): Fix LlamaIndex spelling and slug in documentation #1929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Corrected spelling of 'LlamaIndex' and updated slug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Comment @cursor review
or bugbot run
to trigger another review on this PR
sidebar_label: LlamaIndex | ||
sidebar_position: 6 | ||
slug: /integrations/llama | ||
slug: /integrations/llama-index, /integrations/llama |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Invalid Slug Syntax Causes Documentation Errors
The slug
frontmatter field uses a comma-separated list of values, which is invalid syntax for most documentation systems (like Docusaurus). These systems typically expect a single string value, so this will likely cause parsing errors, malformed URLs, or prevent the intended creation of multiple aliases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. @TC-MO please is there some other way to keep supporting the old URL with a redirect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only through nginx.conf
redirect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should handle the change of slug so old URL still leads to new one, I can move forward and add it
rewrite ^/platform/integrations/llama$ /platform/integrations/llama-index permanent;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cursoragent please update the PR with the above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to authenticate your request. Please make sure to connect your GitHub account to Cursor. Go to Cursor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try again now
@TC-MO fixed now I hope |
feel free to merge once approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but with redirects I think there is only one way to find out
Ah w8, the build is failing, I know the issue, there is a link in main integrations page, I'll fix it and merge it |
Yolo! Thanks Michal |
Preview for this PR was built for commit |
All green, merging and once it's built I'll check if the redirect works properly |
Corrected spelling of 'LlamaIndex' and updated slug.