fix: remove unused dependencies from package.json
#1953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: B4nan <615580+B4nan@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
B4nan
September 29, 2025 08:02
B4nan
approved these changes
Sep 29, 2025
B4nan
changed the title
|
Preview for this PR was built for commit |
1 similar comment
|
Preview for this PR was built for commit |
barjin
changed the title
package.json
barjin
approved these changes
Sep 29, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: PR Mismatch: Critical Dependencies Removed
The PR description states only globby is removed, but the changes actually remove 12 other dependencies, including critical Docusaurus core, MDX, and ESLint packages. This mismatch misrepresents the PR's scope, making it difficult to review and likely breaking build and functionality.
package.json#L45-L88
Lines 45 to 88 in 68bd577
Comment @cursor review or bugbot run to trigger another review on this PR
|
Preview for this PR was built for commit |
patrikbraborec
pushed a commit
that referenced
this pull request
Sep 29, 2025
The `globby` package was listed as a direct dependency in `devDependencies` but is not actually used anywhere in the codebase. This dependency is only needed as a transitive dependency through existing packages. ## Analysis A comprehensive search of the codebase revealed: - No direct imports or usage of `globby` in any source files - `globby` is available as a transitive dependency through: - `@docusaurus/core` → `@docusaurus/bundler` → `copy-webpack-plugin` → `globby@13.2.2` - `@docusaurus/utils` → `globby@11.1.0` ## Changes - Removed `"globby": "^14.0.0"` from `devDependencies` in `package.json` - Updated `package-lock.json` to reflect the removal of the extraneous package ## Testing All functionality remains intact after the removal: - ✅ ESLint and code linting work correctly - ✅ Markdown linting works correctly - ✅ API documentation build (`redoc:test`) succeeds - ✅ Docusaurus core functionality is unaffected - ✅ Transitive dependencies continue to provide needed functionality This change follows best practices by only listing packages as direct dependencies when they are actually imported or used directly in the project code. > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `otel.cloud.redocly.com` > - Triggering command: `node /home/REDACTED/work/apify-docs/apify-docs/node_modules/.bin/redocly lint` (dns block) > - Triggering command: `node /home/REDACTED/work/apify-docs/apify-docs/node_modules/.bin/redocly bundle apify-api/openapi/openapi.yaml -o apify-api` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/apify/apify-docs/settings/copilot/coding_agent) (admins only) > > </details> <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > remove dependency on globby from package.json, it is not used directly, only as part of our dependencies </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Removes several unused dependencies/devDependencies from `package.json` and updates `package-lock.json` accordingly. > > - **Dependencies cleanup**: > - Remove unused `@docusaurus/utils`, `@mdx-js/react`, `ajv`, `form-data`, `proxy-from-env`, `search-insights`. > - **DevDependencies cleanup**: > - Remove unused `@rsbuild/plugin-styled-components`, `eslint-plugin-json`, `eslint-plugin-markdown`, `eslint-plugin-react-hooks`, `fs-extra`, `globby`. > - **Lockfile**: > - Prunes corresponding entries from `package-lock.json`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 68bd577. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: B4nan <615580+B4nan@users.noreply.github.com> Co-authored-by: Jindřich Bär <jindrichbar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
globbypackage was listed as a direct dependency indevDependenciesbut is not actually used anywhere in the codebase. This dependency is only needed as a transitive dependency through existing packages.Analysis
A comprehensive search of the codebase revealed:
globbyin any source filesglobbyis available as a transitive dependency through:@docusaurus/core→@docusaurus/bundler→copy-webpack-plugin→globby@13.2.2@docusaurus/utils→globby@11.1.0Changes
"globby": "^14.0.0"fromdevDependenciesinpackage.jsonpackage-lock.jsonto reflect the removal of the extraneous packageTesting
All functionality remains intact after the removal:
redoc:test) succeedsThis change follows best practices by only listing packages as direct dependencies when they are actually imported or used directly in the project code.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
otel.cloud.redocly.comnode /home/REDACTED/work/apify-docs/apify-docs/node_modules/.bin/redocly lint(dns block)node /home/REDACTED/work/apify-docs/apify-docs/node_modules/.bin/redocly bundle apify-api/openapi/openapi.yaml -o apify-api(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Note
Removes several unused dependencies/devDependencies from
package.jsonand updatespackage-lock.jsonaccordingly.@docusaurus/utils,@mdx-js/react,ajv,form-data,proxy-from-env,search-insights.@rsbuild/plugin-styled-components,eslint-plugin-json,eslint-plugin-markdown,eslint-plugin-react-hooks,fs-extra,globby.package-lock.json.Written by Cursor Bugbot for commit 68bd577. This will update automatically on new commits. Configure here.