Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace relative imports rather with absolute ones #160

Closed
vdusek opened this issue Jan 3, 2024 · 0 comments · Fixed by #177
Closed

Replace relative imports rather with absolute ones #160

vdusek opened this issue Jan 3, 2024 · 0 comments · Fixed by #177
Assignees
@vdusek
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.
Milestone
81st sprint - Too...

Comments

@vdusek
Copy link
Contributor

vdusek commented Jan 3, 2024 •
edited

e.g.

- from ...actor import Actor
+ from apify import Actor
@vdusek vdusek added debt Code quality improvement or decrease of technical debt. low priority Low priority issues to be done eventually. t-tooling Issues with this label are in the ownership of the tooling team. labels Jan 3, 2024
@vdusek vdusek self-assigned this Jan 3, 2024
@vdusek vdusek mentioned this issue Jan 3, 2024
Merged
@vdusek vdusek added this to the 80th sprint - Tooling team milestone Jan 3, 2024
honzajavorek added a commit to honzajavorek/apify-sdk-python that referenced this issue Jan 3, 2024
@honzajavorek
Use absolute imports
c44b672 
Implements apify#160, with
exception of tests, where the relative imports make some sense
and removing them would mean re-architecturing the tests.
@honzajavorek honzajavorek mentioned this issue Jan 3, 2024
Closed
@vdusek vdusek removed the low priority Low priority issues to be done eventually. label Jan 8, 2024
vdusek pushed a commit that referenced this issue Jan 19, 2024
@honzajavorek @vdusek
Use absolute imports
126dd59 
Implements #160, with
exception of tests, where the relative imports make some sense
and removing them would mean re-architecturing the tests.
@vdusek vdusek mentioned this issue Jan 19, 2024
Merged
vdusek added a commit that referenced this issue Jan 19, 2024
@vdusek @honzajavorek
Use absolute imports (#177)
708078b 
Closes #160

Co-authored-by: Honza Javorek <mail@honzajavorek.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vdusek vdusek

Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
81st sprint - Tooling team
Development

Successfully merging a pull request may close this issue.

Use absolute imports apify/apify-sdk-python
1 participant
@vdusek