chore: Code quality improvements

[jirimoravcik]

I used https://pypi.org/project/flake8_simplify/ to get some insights and improved the code a bit

[vdusek]

LGTM

[fnesveda]

Cool!

[vdusek]

What about adding the flake8_simplify package to the dev dependencies?

[jirimoravcik]

What about adding the flake8_simplify package to the dev dependencies?

Yeah, I though about it. It reports some stuff that I didn't want to change :D (specifically, using context managers for files - we have code that does open(..).close() which is shorter than using a context manager. But I think it's fine

[jirimoravcik]

Added flake8-simplify as dev dependency. Will also do for other 2 repos along with code simplification

[vdusek]

Yeah, I though about it. It reports some stuff that I didn't want to change :D (specifically, using context managers for files - we have code that does open(..).close() which is shorter than using a context manager.

I'd use #noqa for such cases, up to you, both variants LGTM.

[jirimoravcik]

Yeah, I though about it. It reports some stuff that I didn't want to change :D (specifically, using context managers for files - we have code that does open(..).close() which is shorter than using a context manager.

I'd use #noqa for such cases, up to you, both variants LGTM.

I just did the suggested change, it's better than noqa or adding the rule to flake ignores