Skip to content

fix: Better event listener type definitions #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 17, 2025
Merged

fix: Better event listener type definitions #354

merged 3 commits into from
Jan 17, 2025

Conversation

janbuchar
Copy link
Contributor

@janbuchar janbuchar commented Dec 10, 2024 •
edited
Loading

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Dec 10, 2024
@github-actions github-actions bot added this to the 104th sprint - Tooling team milestone Dec 10, 2024
janbuchar
janbuchar commented Dec 10, 2024
View reviewed changes
vdusek
vdusek approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbuchar janbuchar marked this pull request as draft December 11, 2024 13:43
@janbuchar
Copy link
Contributor Author

Converted to draft until changes in Crawlee are released

@janbuchar janbuchar marked this pull request as ready for review January 16, 2025 09:55
@janbuchar janbuchar requested a review from vdusek January 16, 2025 09:56
vdusek
vdusek approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit 52a6dee into master Jan 17, 2025
27 checks passed
@vdusek vdusek deleted the better-event-listener-typing branch January 17, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

@Pijukatel Pijukatel Awaiting requested review from Pijukatel

Assignees

@janbuchar janbuchar

Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
104th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.

Allow registering event handlers that do not accept any parameters
2 participants
@janbuchar @vdusek