Skip to content

Conversation

fnesveda
Copy link
Member

This adds integration tests for:

  • Actor.is_at_home
  • Actor.get_env
  • Actor.new_client
  • Actor.start
  • Actor.call
  • Actor.call_task
  • Actor.abort
  • Actor.metamorph
  • Actor.reboot
  • Actor.add_webhook
  • Actor.set_status_message

@fnesveda fnesveda added the t-core-services Issues with this label are in the ownership of the core services team. label Jan 31, 2023
@fnesveda fnesveda added this to the 56th sprint - Platform team milestone Jan 31, 2023
@fnesveda fnesveda self-assigned this Jan 31, 2023
Copy link
Member

@drobnikj drobnikj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are pretty cool. Just one consts recommendation.

run_result = await actor.call()

assert run_result is not None
assert run_result['status'] == 'SUCCEEDED'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put statuses into _consts.py. I think we will need them across all integration tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These consts are in apify-client, I would reexport them from there for now, until we have some shared package with consts and utils, but I didn't want to do it in this PR to make it more complicated.

@mtrunkat
Copy link
Member

mtrunkat commented Feb 1, 2023

obrazek

Base automatically changed from feature/integration-tests-in-ci to master February 1, 2023 17:13
@fnesveda fnesveda force-pushed the feature/integration-tests-for-actor-helpers branch from 439db7d to 0c1cb4e Compare February 1, 2023 17:17
@fnesveda fnesveda merged commit 7f4dcad into master Feb 2, 2023
@fnesveda fnesveda deleted the feature/integration-tests-for-actor-helpers branch February 2, 2023 09:33
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-core-services Issues with this label are in the ownership of the core services team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants