Skip to content

chore: Resolve PytestWarning in test_invalid_args #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

chore: Resolve PytestWarning in test_invalid_args #557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/unit/test_proxy_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,17 @@ def test_invalid_arguments() -> None:
(['abc', 'DEF', 'geh$'], 2),
([111, 'DEF', 'geh$'], 2),
]:
with pytest.raises(ValueError, match=re.escape(str(invalid_groups[bad_group_index]))): # type: ignore[index]
bad_group = str(invalid_groups[bad_group_index]) # type: ignore[index]

# Match the actual error message pattern that includes the value and argument name
match_pattern = f'Value {re.escape(bad_group)} of argument groups does not match pattern'

with pytest.raises(ValueError, match=match_pattern):
ProxyConfiguration(groups=invalid_groups) # type: ignore[arg-type]

for invalid_country_code in ['CZE', 'aa', 'DDDD', 1111]:
with pytest.raises(ValueError, match=re.escape(str(invalid_country_code))):
match_pattern = f'Value {re.escape(str(invalid_country_code))} of argument country_code does not match pattern'
with pytest.raises(ValueError, match=match_pattern):
ProxyConfiguration(country_code=invalid_country_code) # type: ignore[arg-type]

with pytest.raises(ValueError, match='Exactly one of .* must be specified'):
Expand Down
Loading