Skip to content

refactor!: Replace httpx with impit #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 21, 2025
Merged

refactor!: Replace httpx with impit #560

merged 5 commits into from
Aug 21, 2025

Conversation

Mantisus
Copy link
Collaborator

Description

  • Replace the usage of HTTPX with Impit

Issues

@Mantisus Mantisus had a problem deploying to fork-pr-integration-tests August 20, 2025 14:17 — with GitHub Actions Failure
@Mantisus Mantisus self-assigned this Aug 20, 2025
@Mantisus Mantisus requested review from vdusek and Pijukatel August 20, 2025 14:17
Pijukatel
Pijukatel approved these changes Aug 20, 2025
View reviewed changes
@Mantisus Mantisus had a problem deploying to fork-pr-integration-tests August 21, 2025 07:00 — with GitHub Actions Failure
@vdusek vdusek had a problem deploying to fork-pr-integration-tests August 21, 2025 08:01 — with GitHub Actions Failure
vdusek
vdusek approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I just removed the httpx from the dev dependencies, we use the tool.mypy.overrides.ignore_missing_imports for such cases, to avoid bloating the dev dependencies.

@vdusek vdusek merged commit cca3869 into apify:master Aug 21, 2025
19 of 21 checks passed
@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

@Pijukatel Pijukatel Pijukatel approved these changes

Assignees

@Mantisus Mantisus

Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace the usage of HTTPX with Impit
3 participants
@Mantisus @vdusek @Pijukatel