Add option to add event handlers which accept no arguments #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, you can add actor event handlers which accept exactly one argument - event data - even if the event itself does not convey any data (like the migration event). If you try to pass an event handler which accepts no arguments, the event handler will throw when the event happens.
Meaning that this does not work:
But this works, because the
MIGRATING
event never has any data:One user was struggling with this, and it's pretty hard to test, especially for the migrations, so I changed the logic so that the first thing works, and the event handler is passed the
event_data
argument only if it can accept it.