Fix detecting signature of built-in functions in event handler #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnesveda
added
bug
jirimoravcik
approved these changes
Mar 29, 2023
drobnikj
approved these changes
Mar 29, 2023
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that
inspect.signature()cannot read the signature of built-in methods, so e.g.Actor.on(ActorEventTypes.SYSTEM_INFO, print)would not work.This fixes it by rewriting the signature-processing to ignore errors when the signature can't be read, and also to better check methods which have default arguments, by just trying to bind the arguments to the method signature.