Set up the repository and move stuff from apify-sdk and apify-client here #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
fnesveda
requested changes
Jul 21, 2023
There was a problem hiding this comment.
Cool! Just some small notes.
And you should also copy the unit tests from https://github.com/apify/apify-sdk-python/blob/master/tests/unit/test_utils.py and https://github.com/apify/apify-sdk-python/blob/master/tests/unit/test_consts.py to here.
|
Thanks, @fnesveda. I fixed the minor issues you mentioned, added unit tests, and also a few lines into README. |
fnesveda
requested changes
Jul 24, 2023
|
Thanks, @fnesveda, it should be fixed now. |
fnesveda
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I separated the PR into 3 commits. At first, I just copied the
apify-client-pythonrepository, and in the next commits, I did the changes to be able to see the changes I made.Basically regarding the project setup I just removed the docs & test stuff.
The content of
src/was discussed on Slack with @fnesveda .Closes #1.