Skip to content

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Nov 20, 2024

Updating the plugin allows us to use the new unified transformation pipeline instead of handling the API docs generation separately in each Python project.

The new version also now renders the Typedoc objects in machine-readable elements on the page, so we can use the new reexports plugin option (more about that in a PR in apify-sdk-python).

@barjin barjin added documentation Improvements or additions to documentation. t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Nov 20, 2024
@barjin barjin requested review from B4nan and vdusek November 20, 2024 09:06
@barjin barjin self-assigned this Nov 20, 2024
@github-actions github-actions bot added this to the 103rd sprint - Tooling team milestone Nov 20, 2024

run-docs: build-api-reference
cd website && corepack enable && yarn && yarn start
cd website && corepack enable && yarn && poetry run yarn start
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the plugin now runs pydoc-markdown (and other python tooling) automatically, we need to run the Docusaurus build with the correct venv using poetry run (hopefully this is how it works).

pythonOptions: {
pythonModulePath: path.join(__dirname, '../src/crawlee'),
moduleShortcutsPath: path.join(__dirname, 'module_shortcuts.json'),
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new unified API docs generating pipeline - we don't need to generate the json ourselves, just supply the path to the project (and the module_shortcuts.json file, which we might want to remove / integrate later, further simplifying the interface).

@barjin barjin merged commit 52a5458 into master Nov 20, 2024
23 checks passed
@barjin barjin deleted the docs/new-docs-plugin branch November 20, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. documentation Improvements or additions to documentation. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants