This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
Send memory usage information together with metrics on Linux #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruohola
force-pushed
the
memory-usage
branch
3 times, most recently
from
96c6290
to
d54fdd2
Compare
ruohola
changed the title
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 83 102 +19
Branches 7 10 +3
=========================================
+ Hits 83 102 +19
Continue to review full report at Codecov.
|
ruohola
force-pushed
the
memory-usage
branch
from
d54fdd2
to
37360ef
Compare
ruohola
force-pushed
the
memory-usage
branch
from
37360ef
to
3f916c0
Compare
We handle only Linux since getting accurate memory usage values on it is most important. Memory cannot be read platform independently in Python and we don't want at this point to include any external dependencies, such as `psutil`. We might want to add support for other systems when the need arises for some user, it likely won't happen soon since since production web servers are not often ran on non-Linux systems. Good to note that `MemAvailable` in `/proc/meminfo` is only available on Linux kernel 3.14 and up, but since 3.14 has already reached end of life we can pretty safely ignore support for systems before it.
Now that we have operating system resource accessing functionality, we really want to test against all the major operating systems.
ruohola
force-pushed
the
memory-usage
branch
from
3f916c0
to
491681e
Compare
blomqma
approved these changes
Feb 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We handle only Linux since getting accurate memory usage values on it is
most important. Memory cannot be read platform independently in Python
and we don't want at this point to include any external dependencies,
such as
psutil. We might want to add support for other systems whenthe need arises for some user, it likely won't happen soon since since
production web servers are not often ran on non-Linux systems.
Good to note that
MemAvailablein/proc/meminfois only available onLinux kernel 3.14 and up, but since 3.14 has already reached end of
life we can pretty safely ignore support for systems before it.