This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
Add platform name to sent Apilytics version info #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 102 101 -1
Branches 10 9 -1
=========================================
- Hits 102 101 -1
Continue to review full report at Codecov.
|
ruohola
force-pushed
the
send-os
branch
4 times, most recently
from
8e1f172
to
6a49c01
Compare
blomqma
approved these changes
Feb 20, 2022
Use `sys.platform` for this (instead of `platform.system()`) since it's more consistent with Node.js's `process.platform` values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
sys.platformfor this (instead ofplatform.system()) since it'smore consistent with Node.js's
process.platformvalues.Atm rebased on top of #14, it should be merged first.