-
Notifications
You must be signed in to change notification settings - Fork 18
re #889 Update Naming #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
OK cool - thanks @kahboom - should I wait to merge until those last 7 are done? |
@EricWittmann - Up to you, I'm guessing it will take me about an hour or two to look over everything, make sure it looks okay, and maybe have time to edit the images. Right now I only need about 4 more posts (no images). |
OK great - I'll wait until you've got the rest ready I guess. :) |
fad4f15
to
f1466a2
Compare
_blog-src/_layouts/post.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: This is a redux of our popular Keycloak OAuth2
I guess this is artefact when you copied over the 'old/new blog post' notices from the KC blogpost. Presume you'll want to make it more generic. In asciidoctor NOTE:
is an admonition, and it doesn't work in markdown, so suggest you kill that bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, good catch. I'm sure that'd confuse quite a few people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msavy - Maybe something like this:
Note: This is a redux of an existing post for apiman 1.2.x. If you're still using apiman 1.1.x, you can refer to the older revision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How’s about:
This is a redux of an existing blogpost for apiman 1.2.x […]
Are you redoing all of them or just popular ones? If only popular ones I vote s/an existing/a popular/
On 11 Jan 2016, at 21:15, Rachel Yordán notifications@github.com wrote:
In _blog-src/_layouts/post.html #38 (comment):
@@ -11,6 +11,21 @@
{{
{{ page.categories | array_to_sentence_string }}
- {% if page.newUrl || page.oldUrl %}
- {% if page.newUrl %}
NOTE: A newer revision of this blogpost correct for apiman 1.2.x is available. This version written for apiman 1.1.x, for which it remains valid.
- {% endif %}
- {% if page.oldUrl %}
NOTE: This is a redux of our popular Keycloak OAuth2 for _apiman 1.2.x_. If you're still using apiman 1.1.x, you can refer to the older revision.
@msavy https://github.com/msavy - Maybe something like this:
Note: This is a redux of an existing post for apiman 1.2.x. If you're still using apiman 1.1.x, you can refer to the older revision.
—
Reply to this email directly or view it on GitHub https://github.com/apiman/apiman.github.io/pull/38/files#r49379648.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msavy - All of them since there were only about 13.
@EricWittmann - I pushed up my changes yesterday, which covers all blog posts, however, I'd like for you to take a look at the EDIT: Oh and will be updating the text @msavy commented on above. Any ideas about what you'd like it to say? |
cc @EricWittmann - Still working on the last 7 blog posts.