Skip to content

Conversation

kahboom
Copy link
Member

@kahboom kahboom commented Jan 11, 2016

cc @EricWittmann - Still working on the last 7 blog posts.

@EricWittmann
Copy link
Member

OK cool - thanks @kahboom - should I wait to merge until those last 7 are done?

@kahboom
Copy link
Member Author

kahboom commented Jan 11, 2016

@EricWittmann - Up to you, I'm guessing it will take me about an hour or two to look over everything, make sure it looks okay, and maybe have time to edit the images. Right now I only need about 4 more posts (no images).

@EricWittmann
Copy link
Member

OK great - I'll wait until you've got the rest ready I guess. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This is a redux of our popular Keycloak OAuth2

I guess this is artefact when you copied over the 'old/new blog post' notices from the KC blogpost. Presume you'll want to make it more generic. In asciidoctor NOTE: is an admonition, and it doesn't work in markdown, so suggest you kill that bit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, good catch. I'm sure that'd confuse quite a few people.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msavy - Maybe something like this:

Note: This is a redux of an existing post for apiman 1.2.x. If you're still using apiman 1.1.x, you can refer to the older revision.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How’s about:

This is a redux of an existing blogpost for apiman 1.2.x […]

Are you redoing all of them or just popular ones? If only popular ones I vote s/an existing/a popular/

On 11 Jan 2016, at 21:15, Rachel Yordán notifications@github.com wrote:

In _blog-src/_layouts/post.html #38 (comment):

@@ -11,6 +11,21 @@

{{
{{ page.categories | array_to_sentence_string }}

  • {% if page.newUrl || page.oldUrl %}
  • {% if page.newUrl %}
  • NOTE: A newer revision of this blogpost correct for apiman 1.2.x is available. This version written for apiman 1.1.x, for which it remains valid.

  • {% endif %}
  • {% if page.oldUrl %}
  • NOTE: This is a redux of our popular Keycloak OAuth2 for _apiman 1.2.x_. If you're still using apiman 1.1.x, you can refer to the older revision.

@msavy https://github.com/msavy - Maybe something like this:

Note: This is a redux of an existing post for apiman 1.2.x. If you're still using apiman 1.1.x, you can refer to the older revision.


Reply to this email directly or view it on GitHub https://github.com/apiman/apiman.github.io/pull/38/files#r49379648.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msavy - All of them since there were only about 13.

@kahboom
Copy link
Member Author

kahboom commented Jan 12, 2016

@EricWittmann - I pushed up my changes yesterday, which covers all blog posts, however, I'd like for you to take a look at the 2015-05-19-rest-api-redux.markdown post to make sure everything was updated properly, as I felt the least confident with those changes. I'm just editing some images for the blog posts now and will do a sweep through in case I broke anything.

EDIT: Oh and will be updating the text @msavy commented on above. Any ideas about what you'd like it to say?

@kahboom
Copy link
Member Author

kahboom commented Jan 12, 2016

screen shot 2016-01-12 at 9 44 50 am

Fixed the styling, updated the text (see screenshot), and fixed an issue where the newer posts were not displaying the notice block. Working on images and also, I'm not sure what we want to do about duplicate entries in the list of blog posts, if anything at all, as that may be confusing for users.

EricWittmann added a commit that referenced this pull request Jan 12, 2016
@EricWittmann EricWittmann merged commit f957517 into apiman:1.2.x Jan 12, 2016
@kahboom kahboom deleted the 889-update-naming branch February 16, 2016 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants