feat: enable experimental multi-arch build for linux/amd64 and linux/arm64 #1103

networkhermit · 2023-07-19T14:10:42Z

Building multi-arch docker image via QEMU emulation is pretty slow, but let's test the build process, if they are too slow maybe we will disable them.

References:

Summary by OpenAI

Release Notes:

New Feature: Experimental multi-architecture builds for linux/amd64 and linux/arm64 have been enabled in Dockerfile build targets.
New Feature: QEMU and Docker Buildx have been set up to enable experimental multi-arch builds for linux/amd64 and linux/arm64.

"Building with grace,
Multi-arch takes its place.
Linux/amd64 and arm64,
Docker's power we explore. 🐳"

…arm64

github-actions · 2023-07-19T14:11:47Z

🤖 OpenAI

High-level Summary

The changes introduce experimental multi-architecture builds for linux/amd64 and linux/arm64 in Dockerfiles. This is achieved by adding the platforms attribute to several build targets. Additionally, the changes set up QEMU and Docker Buildx in the GitHub workflow file to enable multi-arch builds.

File Summaries

File	Summary
.docker-bake.hcl	The diff adds the `platforms` attribute to several build targets in a Dockerfile. It enables experimental multi-architecture builds for `linux/amd64` and `linux/arm64`.
.github/workflows/build.yaml	Enable experimental multi-arch build for linux/amd64 and linux/arm64 by setting up QEMU and Docker Buildx.

These changes aim to enhance the flexibility and compatibility of the Docker images by enabling builds for multiple architectures.

Chat with 🤖 OpenAI Bot (`@openai`)

Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
Invite the bot into a review comment chain by tagging @openai in a reply.

Code suggestions

The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Ignoring further reviews

Type @openai: ignore anywhere in the PR description to ignore further reviews from the bot.

In the recent run, only the files that changed from the base of the PR and between 55766a979631338ae1cdb8e2524c319bb5c427bb and 9ce8ce3708eb75e4bc6d32824d93c2c57f73c9a2 commits were reviewed.

github-actions · 2023-07-19T14:11:50Z

.github/workflows/build.yaml

    steps:
      - name: Fetch Sources
        uses: actions/checkout@v3
+      - name: Set up QEMU


🤖 OpenAI

The indentation of steps 72-75 is incorrect. It should be aligned with the previous step. Please fix the indentation.

github-actions · 2023-07-19T14:11:53Z

.github/workflows/build.yaml

+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v2


🤖 OpenAI

The indentation of steps 76-77 is incorrect. It should be aligned with the previous step. Please fix the indentation.

github-actions · 2023-07-19T14:11:56Z

.github/workflows/build.yaml

        run: |
          eval "$(./scripts/semver-ci.sh)"


🤖 OpenAI

The command eval "$(./scripts/semver-ci.sh)" is not clear in terms of its purpose and what it does. Please provide more context or documentation for this command to improve clarity.

github-actions · 2023-07-19T14:11:59Z

docker-bake.hcl

  args = {
    SEMVER_FULL = SEMVER_FULL
  }
+  platforms = ["linux/amd64", "linux/arm64"]
  tags = ["${IMAGE_REGISTRY}/apitable/backend-server:latest", "${IMAGE_REGISTRY}/apitable/backend-server:${IMAGE_TAG}"]
 }



🤖 OpenAI

The platforms attribute has been added to specify the target architectures for building the Docker image. However, it seems that the args attribute is no longer needed and can be removed. Additionally, it would be beneficial to add a comment explaining the purpose of the platforms attribute.

Suggested change

args = {

SEMVER_FULL = SEMVER_FULL

}

platforms = ["linux/amd64", "linux/arm64"]

tags = ["${IMAGE_REGISTRY}/apitable/backend-server:latest", "${IMAGE_REGISTRY}/apitable/backend-server:${IMAGE_TAG}"]

}

platforms = ["linux/amd64", "linux/arm64"]

tags = ["${IMAGE_REGISTRY}/apitable/backend-server:latest", "${IMAGE_REGISTRY}/apitable/backend-server:${IMAGE_TAG}"]

}

github-actions · 2023-07-19T14:12:02Z

docker-bake.hcl

  args = {
    SEMVER_FULL = SEMVER_FULL
  }
+  platforms = ["linux/amd64", "linux/arm64"]
  tags = ["${IMAGE_REGISTRY}/apitable/room-server:latest", "${IMAGE_REGISTRY}/apitable/room-server:${IMAGE_TAG}"]
 }



🤖 OpenAI

Similar to the previous change, the platforms attribute has been added. The args attribute can be removed, and a comment explaining the platforms attribute would be helpful.

Suggested change

args = {

SEMVER_FULL = SEMVER_FULL

}

platforms = ["linux/amd64", "linux/arm64"]

tags = ["${IMAGE_REGISTRY}/apitable/room-server:latest", "${IMAGE_REGISTRY}/apitable/room-server:${IMAGE_TAG}"]

}

platforms = ["linux/amd64", "linux/arm64"]

tags = ["${IMAGE_REGISTRY}/apitable/room-server:latest", "${IMAGE_REGISTRY}/apitable/room-server:${IMAGE_TAG}"]

}

github-actions · 2023-07-19T14:12:05Z

docker-bake.hcl

  args = {
    SEMVER_FULL = SEMVER_FULL
  }
+  platforms = ["linux/amd64", "linux/arm64"]
  tags = ["${IMAGE_REGISTRY}/apitable/web-server:latest", "${IMAGE_REGISTRY}/apitable/web-server:${IMAGE_TAG}"]
 }



🤖 OpenAI

The platforms attribute has been added again. Remove the args attribute and consider adding a comment to explain the purpose of the platforms attribute.

Suggested change

args = {

SEMVER_FULL = SEMVER_FULL

}

platforms = ["linux/amd64", "linux/arm64"]

tags = ["${IMAGE_REGISTRY}/apitable/web-server:latest", "${IMAGE_REGISTRY}/apitable/web-server:${IMAGE_TAG}"]

}

platforms = ["linux/amd64", "linux/arm64"]

tags = ["${IMAGE_REGISTRY}/apitable/web-server:latest", "${IMAGE_REGISTRY}/apitable/web-server:${IMAGE_TAG}"]

}

github-actions · 2023-07-19T14:12:08Z

docker-bake.hcl

  args = {
    SEMVER_FULL = SEMVER_FULL
  }
+  platforms = ["linux/amd64", "linux/arm64"]
  tags = ["${IMAGE_REGISTRY}/apitable/init-db:latest", "${IMAGE_REGISTRY}/apitable/init-db:${IMAGE_TAG}"]
 }



🤖 OpenAI

The platforms attribute has been added once more. Remove the args attribute and consider adding a comment to clarify the intention of the platforms attribute.

Suggested change

args = {

SEMVER_FULL = SEMVER_FULL

}

platforms = ["linux/amd64", "linux/arm64"]

tags = ["${IMAGE_REGISTRY}/apitable/init-db:latest", "${IMAGE_REGISTRY}/apitable/init-db:${IMAGE_TAG}"]

}

platforms = ["linux/amd64", "linux/arm64"]

tags = ["${IMAGE_REGISTRY}/apitable/init-db:latest", "${IMAGE_REGISTRY}/apitable/init-db:${IMAGE_TAG}"]

}

github-actions · 2023-07-19T14:12:11Z

docker-bake.hcl

  args = {
    SEMVER_FULL = SEMVER_FULL
  }
+  platforms = ["linux/amd64", "linux/arm64"]
  tags = ["${IMAGE_REGISTRY}/apitable/openresty:latest", "${IMAGE_REGISTRY}/apitable/openresty:${IMAGE_TAG}"]
 }



🤖 OpenAI

The platforms attribute has been added. Remove the args attribute and consider adding a comment to explain the purpose of the platforms attribute.

Suggested change

args = {

SEMVER_FULL = SEMVER_FULL

}

platforms = ["linux/amd64", "linux/arm64"]

tags = ["${IMAGE_REGISTRY}/apitable/openresty:latest", "${IMAGE_REGISTRY}/apitable/openresty:${IMAGE_TAG}"]

}

platforms = ["linux/amd64", "linux/arm64"]

tags = ["${IMAGE_REGISTRY}/apitable/openresty:latest", "${IMAGE_REGISTRY}/apitable/openresty:${IMAGE_TAG}"]

}

github-actions · 2023-07-19T14:12:14Z

docker-bake.hcl

    SEMVER_FULL = SEMVER_FULL
    IMAGE_TAG = IMAGE_TAG
  }
+  platforms = ["linux/amd64"]
  tags = ["${IMAGE_REGISTRY}/apitable/all-in-one:latest", "${IMAGE_REGISTRY}/apitable/all-in-one:${IMAGE_TAG}"]
 }


🤖 OpenAI

The platforms attribute has been added. Remove the args attribute and consider adding a comment to clarify the intention of the platforms attribute.

Suggested change

SEMVER_FULL = SEMVER_FULL

IMAGE_TAG = IMAGE_TAG

}

platforms = ["linux/amd64"]

tags = ["${IMAGE_REGISTRY}/apitable/all-in-one:latest", "${IMAGE_REGISTRY}/apitable/all-in-one:${IMAGE_TAG}"]

}

platforms = ["linux/amd64"]

tags = ["${IMAGE_REGISTRY}/apitable/all-in-one:latest", "${IMAGE_REGISTRY}/apitable/all-in-one:${IMAGE_TAG}"]

}

feat: enable experimental multi-arch build for linux/amd64 and linux/…

9ce8ce3

…arm64

github-actions bot reviewed Jul 19, 2023

View reviewed changes

arucil approved these changes Jul 19, 2023

View reviewed changes

networkhermit merged commit a171d56 into develop Jul 19, 2023
19 of 21 checks passed

networkhermit deleted the feat/enable-experimental-multi-arch-build branch July 19, 2023 14:29

networkhermit linked an issue Jul 20, 2023 that may be closed by this pull request

feat: Docker ARM 版本镜像（pre-init-db、init-db和init-appdata） #828

Closed

networkhermit mentioned this pull request Jul 20, 2023

fix: arm64 room-server missing .lua and .proto files #1107

Open

networkhermit linked an issue Jul 20, 2023 that may be closed by this pull request

feat: arm64 dual image build #66

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enable experimental multi-arch build for linux/amd64 and linux/arm64 #1103

feat: enable experimental multi-arch build for linux/amd64 and linux/arm64 #1103

networkhermit commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023

github-actions bot Jul 19, 2023

github-actions bot Jul 19, 2023

github-actions bot Jul 19, 2023

github-actions bot Jul 19, 2023

github-actions bot Jul 19, 2023

github-actions bot Jul 19, 2023

github-actions bot Jul 19, 2023

github-actions bot Jul 19, 2023

github-actions bot Jul 19, 2023

		- name: Set up Docker Buildx
		uses: docker/setup-buildx-action@v2

feat: enable experimental multi-arch build for linux/amd64 and linux/arm64 #1103

feat: enable experimental multi-arch build for linux/amd64 and linux/arm64 #1103

Conversation

networkhermit commented Jul 19, 2023 • edited Loading

Summary by OpenAI

github-actions bot commented Jul 19, 2023

High-level Summary

File Summaries

Chat with 🤖 OpenAI Bot (@openai)

Code suggestions

Ignoring further reviews

github-actions bot Jul 19, 2023

Choose a reason for hiding this comment

github-actions bot Jul 19, 2023

Choose a reason for hiding this comment

github-actions bot Jul 19, 2023

Choose a reason for hiding this comment

github-actions bot Jul 19, 2023

Choose a reason for hiding this comment

github-actions bot Jul 19, 2023

Choose a reason for hiding this comment

github-actions bot Jul 19, 2023

Choose a reason for hiding this comment

github-actions bot Jul 19, 2023

Choose a reason for hiding this comment

github-actions bot Jul 19, 2023

Choose a reason for hiding this comment

github-actions bot Jul 19, 2023

Choose a reason for hiding this comment

networkhermit commented Jul 19, 2023 •

edited

Loading

Chat with 🤖 OpenAI Bot (`@openai`)