Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build for a more modern target #1286

Merged
merged 7 commits into from
Mar 22, 2024
Merged

Build for a more modern target #1286

merged 7 commits into from
Mar 22, 2024

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Mar 21, 2024 •
edited
Loading

image
🎉

@phryneas phryneas requested a review from a team as a code owner March 21, 2024 10:44
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 21, 2024 •
edited
Loading

Job #118: Bundle Size — 849.39KiB (-23.94%).

058c52b(current) vs 3f60ac7 main#117(baseline)

Warning

Bundle contains 5 duplicate packages – View duplicate packages

Bundle metrics  Change 6 changes Regression 2 regressions Improvement 2 improvements
                 Current
Job #118		      Baseline
Job #117
Improvement  Initial JS 811.99KiB(-24.77%) 1.05MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 96.65% 0%
No change  Chunks 5 5
No change  Assets 12 12
Change  Modules 638(+29.94%) 491
Regression  Duplicate Modules 35(+20.69%) 29
Regression  Duplicate Code 5.22%(+21.96%) 4.28%
Improvement  Packages 58(-3.33%) 60
No change  Duplicate Packages 4 4
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #118		      Baseline
Job #117
Improvement  JS 811.99KiB (-24.77%) 1.05MiB
Not changed  IMG 35.85KiB 35.85KiB
Not changed  HTML 810B 810B
Not changed  Other 778B 778B

View job #118 report View pr/modern-target branch activity View project dashboard

jerelmiller
jerelmiller approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding a changeset before merging this? Otherwise looks great!

package.json
@@ -27,7 +28,7 @@
"firefox": "npm run build:dev -- --watch --env TARGET=firefox",
"format": "prettier --write .",
"check:format": "prettier --check .",
"lint": "eslint . --ext .js,.jsx,.ts,.tsx",
"lint": "ESLINT_USE_FLAT_CONFIG=true yarn eslint src",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

jerelmiller
jerelmiller reviewed Mar 22, 2024
View reviewed changes
tsconfig.json Outdated
@@ -1,13 +1,15 @@
{
"compilerOptions": {
"allowJs": true,
"checkJs": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be causing problems with the all-clients package since it uses .mjs with import attributes. I can get this to build if I remove this line (though I understand why you enabled it). Just an FYI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... let's skip it for now.

@phryneas phryneas merged commit 11309f3 into main Mar 22, 2024
9 checks passed
@phryneas phryneas deleted the pr/modern-target branch March 22, 2024 16:22
@github-actions github-actions bot mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerelmiller jerelmiller jerelmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phryneas @jerelmiller