0.10.0 (3) switch rehydration mismatch protection to useSyncExternalStore
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
commented
Feb 20, 2024
| // one rerender with the actual client value (which is hopefull equal) | ||
| assert.equal(finishedRenderCount, 2); | ||
| assert.equal(finishedRenderCount, 1); |
There was a problem hiding this comment.
This is a nice improvement since it removes a double render that would in reality only be necessary on a server<->client race condition.
phryneas
commented
Feb 20, 2024
| } | ||
|
|
||
| await testIn("browser")( | ||
| "race condition: client ahead of server renders without hydration mismatch", |
There was a problem hiding this comment.
Our first test that directly tests stream rehydration 🎉
size-limit report 📦
|
Job #107: Bundle Size — 1.01MiB (~-0.01%).Warning Bundle contains 1 duplicate package – View duplicate packages Bundle metrics
|
| Current Job #107 |
Baseline Job #104 |
|
|---|---|---|
 Initial JS |
890.58KiB(~-0.01%) |
890.59KiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
21.11% |
0.04% |
| Chunks |
24 |
24 |
| Assets |
45 |
45 |
| Modules |
512 |
512 |
| Duplicate Modules |
30 |
30 |
| Duplicate Code |
1.29% |
1.29% |
| Packages |
29 |
29 |
| Duplicate Packages |
1 |
1 |
Bundle size by type 1 change 1 improvement
| Current Job #107 |
Baseline Job #104 |
|
|---|---|---|
| JS |
1023.84KiB (~-0.01%) |
1023.85KiB |
| Other |
5.99KiB |
5.99KiB |
View job #107 report View pr/uSES branch activity View project dashboard
phryneas
changed the title
useSyncExternalStoreuseSyncExternalStore
jerelmiller
reviewed
Mar 27, 2024
packages/client-react-streaming/src/DataTransportAbstraction/WrappedApolloClient.test.tsx
Outdated
Show resolved
Hide resolved
jerelmiller
reviewed
Mar 27, 2024
| document.body.innerHTML, | ||
| `<!--$--><div id="user">Future me.</div><div id="parallel">suspending in parallel</div><!--/$-->` | ||
| ); | ||
| } |
…rappedApolloClient.test.tsx Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would have been the right implementation from the start, but we couldn't do it in the beginning because of a bug in the canary version used at that time. Now it seems to be working nicely.