fix: strengthen MockedResponse.newData type (#11584)

[Stephen2]

Checklist:

• If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
• If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests

Closes #11584

[apollo-cla]

@Stephen2: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

[netlify]

👷 Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	ad70890

[changeset-bot]

🦋 Changeset detected

Latest commit: ad70890

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[jerelmiller]

Hey @Stephen2 👋

Thanks so much for this contribution! This is super helpful and I'm honestly surprised we didn't do this sooner. I just had a few comments for you in regards to structuring the tests that I'd like to see changed, but otherwise I'd love to get this in the next patch. Thanks a bunch!

[jerelmiller]

@Stephen2 for the CircleCI Pipeline, I think you have to login there for those checks to run. Would you mind trying that?

[Stephen2]

@Stephen2 for the CircleCI Pipeline, I think you have to login there for those checks to run. Would you mind trying that?

Just did this, created new account, signed in, but still wouldn't let me rerun this pipeline

[Stephen2]

Took some liberties with your comments, but I think I captured the intention. Check it out again, ready for re-review

[jerelmiller]

Last round of comments! Thanks for bearing with me 🙂. This should be the last round of updates. I'd be happy to merge once addressed!

[jerelmiller]

Just did this, created new account, signed in, but still wouldn't let me rerun this pipeline

Dang I was hoping this would do it 😞. Just to double check, is the email address you're using here on GitHub the same as CircleCI? Let me also ask around and see if I can figure out why those checks won't run.

[Stephen2]

Just to double check, is the email address you're using here on GitHub the same as CircleCI?

Yeah, it definitely is.

Maybe it's easier if you were to copy/paste these into a separate MR, or something, under your name? idk

[jerelmiller]

I'll try pushing a tiny edit to this branch and see if perhaps that will kick it off? So sorry for the inconvenience here!

[jerelmiller]

The setup function still feels a tad overabstracted, but I can live with it. Thanks for making these updates! Don't worry about the extract API task failing. I'll get a commit pushed up to make this pass 🙂

[jerelmiller]

@Stephen2 would you mind running npm run format and pushing that change? I'd be happy to do it if need be, but I'd prefer you get credit for those lines of code written 🙂

[Stephen2]

The setup function still feels a tad overabstracted, but I can live with it. Thanks for making these updates! Don't worry about the extract API task failing. I'll get a commit pushed up to make this pass 🙂

Nah it's great, it'll grow on you. xD

You're a good maintainer, I appreciate you.

Hopefully we're ready to squash & merge now, except I think CircleCI needs to be kicked again :(

[jerelmiller]

Argh, that darn circle job. I'll get that kicked off again. As soon as thats green, I'm happy to merge this! We'll get this in the next patch release.

And thanks so much for the kind comments 🙂. Means a lot!