-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch useRenderGuard
to an approach not accessing React's internals
#11888
Conversation
🦋 Changeset detectedLatest commit: 332ffd0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever! I'm really happy we're able to keep this around. Nice work!
@@ -1,4 +1,4 @@ | |||
{ | |||
"dist/apollo-client.min.cjs": 39620, | |||
"dist/apollo-client.min.cjs": 39561, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
This switches
useRenderGuard
to an approach that is not accessing React's internals, and we should even safe some bundle size 🎉